Generics and casting – cannot cast inherited class to base class

by

RepositoryBase<EntityBase> is not a base class of MyEntityRepository. You’re looking for generic variance which exists in C# to a limited extent, but wouldn’t apply here.

Suppose your RepositoryBase<T> class had a method like this:

void Add(T entity) { ... }

Now consider:

MyEntityRepository myEntityRepo = GetMyEntityRepo(); // whatever
RepositoryBase<EntityBase> baseRepo = (RepositoryBase<EntityBase>)myEntityRepo; 
baseRepo.Add(new OtherEntity(...));

Now you’ve added a different kind of entity to a MyEntityRepository… and that can’t be right.

Basically, generic variance is only safe in certain situations. In particular generic covariance (which is what you’re describing here) is only safe when you only ever get values “out” of the API; generic contravariance (which works the other way round) is only safe when you only ever put values “into” the API (e.g. a general comparison which can compare any two shapes by area can be considered as a comparison of squares).

In C# 4 this is available for generic interfaces and generic delegates, not classes – and only with reference types. See MSDN for further information, read <plug>read C# in Depth, 2nd edition, chapter 13</plug> or Eric Lippert’s blog series on the topic. Also, I gave a one hour talk about this at NDC in July 2010 – the video is available here.

More Related Contents:

  1. Value of type ‘T’ cannot be converted to
  2. implicit operator using interfaces
  3. Specifying generic collection type param at runtime [duplicate]
  4. Generics: casting and value types, why is this illegal?
  5. Why can’t I cast from a List to List?
  6. Cast Int to Generic Enum in C#
  7. .NET Casting Generic List
  8. Casting array to IEnumerable
  9. Casting vs using the ‘as’ keyword in the CLR
  10. What exactly is an “open generic type” in .NET? [duplicate]
  11. How can I return NULL from a generic method in C#?
  12. Why must I provide explicitly generic parameter types While the compiler should infer the type?
  13. convert a list of objects from one type to another using lambda expression
  14. Why does “int[] is uint[] == true” in C#
  15. Convert string to nullable type (int, double, etc…)
  16. convert double to int
  17. Cast LINQ result to ObservableCollection
  18. Is there a C# generic constraint for “real number” types? [duplicate]
  19. Why does IEnumerator inherit from IDisposable while the non-generic IEnumerator does not?
  20. Generic methods and method overloading
  21. ThreadStatic v.s. ThreadLocal: is generic better than attribute?
  22. Why can’t Double be implicitly cast to Decimal
  23. What is the difference between casting and conversion? [duplicate]
  24. Can I have a variable number of generic parameters?
  25. What is the equivalent of Java wildcards in C# generics
  26. Overload resolution issue for generic method with constraints
  27. The given key was not present in the dictionary. Which key?
  28. How to make correct clone of the List? [duplicate]
  29. Can you use “where” to require an attribute in c#?
  30. C# List: why you cannot do `List foo = new List();`

Leave a Comment