How to delete an element from a vector while looping over it?

by

The idiomatic way to remove all elements from an STL container which satisfy a given predicate is to use the remove-erase idiom. The idea is to move the predicate (that’s the function which yields true or false for some element) into a given function, say pred and then:

static bool pred( const std::string &s ) {
  // ...
}

std::vector<std::string> v;
v.erase( std::remove_if( v.begin(), v.end(), pred ), v.end() );

If you insist on using indices, you should not increment the index for every element, but only for those which didn’t get removed:

std::vector<std::string>::size_type i = 0;
while ( i < v.size() ) {
    if ( shouldBeRemoved( v[i] ) ) {
        v.erase( v.begin() + i );
    } else {
        ++i;
    }
}

However, this is not only more code and less idiomatic (read: C++ programmers actually have to look at the code whereas the ‘erase & remove’ idiom immediately gives some idea what’s going on), but also much less efficient because vectors store their elements in one contiguous block of memory, so erasing on positions other than the vector end also moves all the elements after the segment erased to their new positions.

More Related Contents:

  1. c++ error : Segmentation fault (core dumped)
  2. Return array in a function
  3. Printing the correct number of decimal points with cout
  4. Programmatically find the number of cores on a machine
  5. Why must the copy assignment operator return a reference/const reference?
  6. Does const mean thread-safe in C++11?
  7. Lock-free Progress Guarantees in a circular buffer queue
  8. What is the ‘this’ pointer?
  9. How to implement make_unique function in C++11? [duplicate]
  10. generate random double numbers in c++
  11. What is the use of having destructor as private?
  12. Bjarne Stroustrup says we must avoid linked lists
  13. How do you append an int to a string in C++? [duplicate]
  14. How do I add a background image to the QMainWindow?
  15. Converting from signed char to unsigned char and back again?
  16. Difference between Enum and Define Statements
  17. Boost::asio – how to interrupt a blocked tcp server thread?
  18. What distinguishes the declaration, the definition and the initialization of a variable?
  19. What does X f() mean?
  20. What is iterator invalidation?
  21. C floating point precision [duplicate]
  22. error: Class has not been declared despite header inclusion, and the code compiling fine elsewhere
  23. When pass-by-pointer is preferred to pass-by-reference in C++?
  24. Address of function is not actual code address
  25. Using char16_t and char32_t in I/O
  26. Cannot open include file: ‘stdio.h’ – Visual Studio Community 2017 – C++ Error
  27. Do C++ enums Start at 0?
  28. How to call function after window is shown?
  29. Debug and Release Library Linking with CMAKE (VISUAL STUDIO)
  30. New (std::nothrow) vs. New within a try/catch block

Leave a Comment