IllegalArgumentException or NullPointerException for a null parameter? [closed]

by

You should be using IllegalArgumentException (IAE), not NullPointerException (NPE) for the following reasons:

First, the NPE JavaDoc explicitly lists the cases where NPE is appropriate. Notice that all of them are thrown by the runtime when null is used inappropriately. In contrast, the IAE JavaDoc couldn’t be more clear: “Thrown to indicate that a method has been passed an illegal or inappropriate argument.” Yup, that’s you!

Second, when you see an NPE in a stack trace, what do you assume? Probably that someone dereferenced a null. When you see IAE, you assume the caller of the method at the top of the stack passed in an illegal value. Again, the latter assumption is true, the former is misleading.

Third, since IAE is clearly designed for validating parameters, you have to assume it as the default choice of exception, so why would you choose NPE instead? Certainly not for different behavior — do you really expect calling code to catch NPE’s separately from IAE and do something different as a result? Are you trying to communicate a more specific error message? But you can do that in the exception message text anyway, as you should for all other incorrect parameters.

Fourth, all other incorrect parameter data will be IAE, so why not be consistent? Why is it that an illegal null is so special that it deserves a separate exception from all other types of illegal arguments?

Finally, I accept the argument given by other answers that parts of the Java API use NPE in this manner. However, the Java API is inconsistent with everything from exception types to naming conventions, so I think just blindly copying (your favorite part of) the Java API isn’t a good enough argument to trump these other considerations.

More Related Contents:

  1. Null check chain vs catching NullPointerException
  2. Avoiding NullPointerException in Java
  3. Why is my Spring @Autowired field null?
  4. Which @NotNull Java annotation should I use?
  5. Should a retrieval method return ‘null’ or throw an exception when it can’t produce the return value? [closed]
  6. How come invoking a (static) method on a null reference doesn’t throw NullPointerException?
  7. Check chains of “get” calls for null
  8. Why does String.valueOf(null) throw a NullPointerException?
  9. Filter values only if not null using lambda in Java8
  10. Is null check needed before calling instanceof?
  11. Why static fields are not initialized in time?
  12. When should an IllegalArgumentException be thrown?
  13. Why use Optional.of over Optional.ofNullable?
  14. How do I avoid checking for nulls in Java?
  15. NumberFormatException not wrking java
  16. How to create exception from another class
  17. Understanding checked vs unchecked exceptions in Java
  18. Why does writeObject throw java.io.NotSerializableException and how do I fix it?
  19. Why is the Catch(Exception) almost always a bad Idea?
  20. Is it possible to catch out of memory exception in java? [duplicate]
  21. How to check if my string is equal to null?
  22. Is it good practice to make the constructor throw an exception? [duplicate]
  23. Update JavaFX UI from another thread
  24. How can I print error stack trace in JSP page?
  25. Converting a Date object to a calendar object [duplicate]
  26. Hibernate order by with nulls last
  27. iText/BouncyCastle ClassNotFound org.bouncycastle.asn1.DEREncodable and org.bouncycastle.tsp.TimeStampTokenInfo
  28. NullPointerException with autoboxing in ternary expression
  29. Why we don’t have to add try-catch to a RuntimeException?
  30. Unable to run JUnit test with PowerMockRunner

Leave a Comment