In Java critical sections, what should I synchronize on?

by

As earlier answerers have noted, it is best practice to synchronize on an object of limited scope (in other words, pick the most restrictive scope you can get away with, and use that.) In particular, synchronizing on this is a bad idea, unless you intend to allow the users of your class to gain the lock.

A particularly ugly case arises, though, if you choose to synchronize on a java.lang.String. Strings can be (and in practice almost always are) interned. That means that each string of equal content – in the ENTIRE JVM – turns out to be the same string behind the scenes. That means that if you synchronize on any String, another (completely disparate) code section that also locks on a String with the same content, will actually lock your code as well.

I was once troubleshooting a deadlock in a production system and (very painfully) tracked the deadlock to two completely disparate open source packages that each synchronized on an instance of String whose contents were both "LOCK".

More Related Contents:

  1. What does ‘synchronized’ mean?
  2. Avoid synchronized(this) in Java?
  3. Difference between volatile and synchronized in Java
  4. Is there an advantage to use a Synchronized Method instead of a Synchronized Block?
  5. Synchronizing on String objects in Java
  6. Java synchronized method lock on object, or method?
  7. Java Synchronized Block for .class
  8. Synchronization of non-final field
  9. Happens-before relationships with volatile fields and synchronized blocks in Java – and their impact on non-volatile variables?
  10. If I synchronized two methods on the same class, can they run simultaneously?
  11. Is ConcurrentHashMap totally safe?
  12. What is the difference between a synchronized method and synchronized block in Java? [duplicate]
  13. Should you synchronize the run method? Why or why not?
  14. Java volatile modifier and synchronized blocks
  15. Java Multithreading concept and join() method
  16. Difference between Synchronized block with wait/notify and without them?
  17. Do two synchronized methods execute simultaneously
  18. If a synchronized method calls another non-synchronized method, is there a lock on the non-synchronized method
  19. How to wait for all threads to finish, using ExecutorService?
  20. java thread.sleep puts swing ui to sleep too
  21. Why use a ReentrantLock if one can use synchronized(this)?
  22. ThreadLocal & Memory Leak
  23. Are volatile variable ‘reads’ as fast as normal reads?
  24. What could be the cause of RejectedExecutionException
  25. Is having a single threadpool better design than multiple threadpools
  26. Why does an IllegalThreadStateException occur when Thread.start is called again
  27. How to get the Context from anywhere? [duplicate]
  28. How to find a Java thread running on Linux with ps -axl?
  29. Is EntityManager really thread-safe?
  30. Executing Dependent tasks in parallel in Java

Leave a Comment