Is ConcurrentHashMap totally safe?

by

The get() method is thread-safe, and the other users gave you useful answers regarding this particular issue.

However, although ConcurrentHashMap is a thread-safe drop-in replacement for HashMap, it is important to realize that if you are doing multiple operations you may have to change your code significantly. For example, take this code:

if (!map.containsKey(key)) 
   return map.put(key, value);
else
   return map.get(key);

In a multi-thread environment, this is a race condition. You have to use the ConcurrentHashMap.putIfAbsent(K key, V value) and pay attention to the return value, which tells you if the put operation was successful or not. Read the docs for more details.

Answering to a comment that asks for clarification on why this is a race condition.

Imagine there are two threads A, B that are going to put two different values in the map, v1 and v2 respectively, having the same key. The key is initially not present in the map. They interleave in this way:

  • Thread A calls containsKey and finds out that the key is not present, but is immediately suspended.
  • Thread B calls containsKey and finds out that the key is not present, and has the time to insert its value v2.
  • Thread A resumes and inserts v1, “peacefully” overwriting (since put is threadsafe) the value inserted by thread B.

Now thread B “thinks” it has successfully inserted its very own value v2, but the map contains v1. This is really a disaster because thread B may call v2.updateSomething() and will “think” that the consumers of the map (e.g. other threads) have access to that object and will see that maybe important update (“like: this visitor IP address is trying to perform a DOS, refuse all the requests from now on”). Instead, the object will be soon garbage collected and lost.

More Related Contents:

  1. What does ‘synchronized’ mean?
  2. Avoid synchronized(this) in Java?
  3. Difference between volatile and synchronized in Java
  4. Is there an advantage to use a Synchronized Method instead of a Synchronized Block?
  5. Synchronizing on String objects in Java
  6. Synchronization vs Lock
  7. Java synchronized method lock on object, or method?
  8. Java Synchronized Block for .class
  9. Synchronization of non-final field
  10. Happens-before relationships with volatile fields and synchronized blocks in Java – and their impact on non-volatile variables?
  11. How many threads are spawned in parallelStream in Java 8?
  12. How to properly use Java Executor?
  13. CompletableFuture is not getting executed. If I use the ExecutorService pool it works as expected but not with the common ForkJoinPool
  14. If I synchronized two methods on the same class, can they run simultaneously?
  15. In Java critical sections, what should I synchronize on?
  16. What is the difference between a synchronized method and synchronized block in Java? [duplicate]
  17. Should you synchronize the run method? Why or why not?
  18. What is adaptive spinning w.r.t lock acquisition?
  19. Run Java Threads sequentially
  20. Java volatile modifier and synchronized blocks
  21. FixedThreadPool vs CachedThreadPool: the lesser of two evils
  22. WAITING at sun.misc.Unsafe.park(Native Method)
  23. Java Multithreading concept and join() method
  24. Difference between Synchronized block with wait/notify and without them?
  25. Thread safe Hash Map?
  26. Do two synchronized methods execute simultaneously
  27. Is having a single threadpool better design than multiple threadpools
  28. If a synchronized method calls another non-synchronized method, is there a lock on the non-synchronized method
  29. ExecutorCompletionService? Why do need one if we have invokeAll?
  30. Which concurrent Queue implementation should I use in Java?

Leave a Comment