Is it an anti-pattern to use async/await inside of a new Promise() constructor?

by

You’re effectively using promises inside the promise constructor executor function, so this the Promise constructor anti-pattern.

Your code is a good example of the main risk: not propagating all errors safely. Read why there.

In addition, the use of async/await can make the same traps even more surprising. Compare:

let p = new Promise(resolve => {
  ""(); // TypeError
  resolve();
});

(async () => {
  await p;
})().catch(e => console.log("Caught: " + e)); // Catches it.

with a naive (wrong) async equivalent:

let p = new Promise(async resolve => {
  ""(); // TypeError
  resolve();
});

(async () => {
  await p;
})().catch(e => console.log("Caught: " + e)); // Doesn't catch it!

Look in your browser’s web console for the last one.

The first one works because any immediate exception in a Promise constructor executor function conveniently rejects the newly constructed promise (but inside any .then you’re on your own).

The second one doesn’t work because any immediate exception in an async function rejects the implicit promise returned by the async function itself.

Since the return value of a promise constructor executor function is unused, that’s bad news!

Your code

There’s no reason you can’t define myFunction as async:

async function myFunction() {
  let array = await getAsyncArray();
  return new Promise((resolve, reject) => {
    eachLimit(array, 500, (item, callback) => {
      // do other things that use native promises.
    }, error => {
      if (error) return reject(error);
      // resolve here passing the next value.
    });
  });
}

Though why use outdated concurrency control libraries when you have await?

More Related Contents:

  1. How to return values from async functions using async-await from function? [duplicate]
  2. SyntaxError: Unexpected token function – Async Await Nodejs
  3. Understanding async/await on NodeJS
  4. using async await and .then together
  5. Does an async function always need to be called with await?
  6. ASYNC / AWAIT SyntaxError: await is only valid in async functions and the top level bodies of modules
  7. Call async/await functions in parallel
  8. How to turn this callback into a promise using async/await?
  9. How to “await” for a callback to return?
  10. nodeJs callbacks simple example
  11. What is the difference between JavaScript promises and async await?
  12. Simplest way to wait some asynchronous tasks complete, in Javascript?
  13. How to wrap async function calls into a sync function in Node.js or Javascript?
  14. Why do I need to await an async function when it is not supposedly returning a Promise?
  15. Are all Node.js callback functions asynchronous?
  16. How to implement a pseudo blocking async queue in JS/TS?
  17. How to know if a function is async?
  18. Node js socket explanation
  19. Async function without await in JavaScript
  20. How to wait until a predicate condition becomes true in JavaScript?
  21. javascript – Why is there a spec for sync and async modules?
  22. How do you create custom asynchronous functions in node.js?
  23. Why is node.js asynchronous?
  24. Is async await truly non-blocking in the browser?
  25. Difference of using async / await vs promises?
  26. Javascript Asynchronous Exception Handling with node.js
  27. How to use the ‘main’ parameter in package.json?
  28. Properly batch nested promises in Node
  29. Using “await” inside non-async function
  30. JavaScript asynchronous programming: promises vs generators

Leave a Comment