Is it really that bad to catch a general exception?

by

Obviously this is one of those questions where the only real answer is “it depends.”

The main thing it depends on is where your are catching the exception. In general libraries should be more conservative with catching exceptions whereas at the top level of your program (e.g. in your main method or in the top of the action method in a controller, etc) you can be more liberal with what you catch.

The reason for this is that e.g. you don’t want to catch all exceptions in a library because you may mask problems that have nothing to do with your library, like “OutOfMemoryException” which you really would prefer bubbles up so that the user can be notified, etc. On the other hand, if you are talking about catching exceptions inside your main() method which catches the exception, displays it and then exits… well, it’s probably safe to catch just about any exception here.

The most important rule about catching all exceptions is that you should never just swallow all exceptions silently… e.g. something like this in Java:

try { 
    something(); 
} catch (Exception ex) {}

or this in Python:

try:
    something()
except:
    pass

Because these can be some of the hardest issues to track down.

A good rule of thumb is that you should only catch exceptions that you can properly deal with yourself. If you cannot handle the exception completely then you should let it bubble up to someone who can.

More Related Contents:

  1. Why not use exceptions as regular flow of control?
  2. Dealing with “java.lang.OutOfMemoryError: PermGen space” error
  3. When to throw an exception?
  4. Better exception for non-exhaustive patterns in case
  5. Why should I not wrap every block in “try”-“catch”?
  6. Could not load file or assembly System.Net.Http.Primitives. Located assembly’s manifest definition does not match the assembly reference
  7. Design by contract using assertions or exceptions? [closed]
  8. Cause of Servlet’s ‘Response Already Committed’ [duplicate]
  9. try-catch exceptions in Swift [duplicate]
  10. Why not catch general Exceptions
  11. When is it right for a constructor to throw an exception?
  12. simple IPython example raises exception on sys.exit()
  13. Why is exception handling bad? [closed]
  14. How do exceptions in Haskell work?
  15. How do I not log a particular type of Exception in Logback?
  16. What is causing my OLEDbException, IErrorInfo.GetDescription failed with E_FAIL(0x80004005)
  17. Why are Exceptions said to be so bad for Input Validation?
  18. Can I get detailed exception stacktrace in PowerShell?
  19. Android, ListView IllegalStateException: “The content of the adapter has changed but ListView did not receive a notification”
  20. Handling exceptions from Java ExecutorService tasks
  21. Avoiding first chance exception messages when the exception is safely handled
  22. java.net.MalformedURLException: no protocol
  23. Toggle “Break when an exception is thrown.” using macro or keyboard shortcut
  24. PKIX path building failed in Java application
  25. String index out of bounds exception java
  26. android.content.res.Resources$NotFoundException: String resource ID #0x1 Error [duplicate]
  27. The given key was not present in the dictionary. Which key?
  28. Is object oriented exception handling in Perl worth it?
  29. How to make [DebuggerNonUserCode] hide an exception from the debugger in simple test case?
  30. maximum size of java class / exception table

Leave a Comment