As answered by Oriol, it doesn’t work because the variable is passed by value, so you’re not changing the “that” variable. A workaround would be to pass the variable name :
that = 0;
function test(input) {
window[input]++;
}
test("that");
console.log(that); // 1