php $_GET and undefined index

by

Error reporting will have not included notices on the previous server which is why you haven’t seen the errors.

You should be checking whether the index s actually exists in the $_GET array before attempting to use it.

Something like this would be suffice:

if (isset($_GET['s'])) {
    if ($_GET['s'] == 'jwshxnsyllabus')
        echo "<body onload=\"loadSyllabi('syllabus', '../syllabi/jwshxnporsyllabus.xml',         '../bibliographies/jwshxnbibliography_')\">";
    else if ($_GET['s'] == 'aquinas')
        echo "<body onload=\"loadSyllabi('syllabus', '../syllabi/AquinasSyllabus.xml')\">"; 
    else if ($_GET['s'] == 'POP2')
        echo "<body onload=\"loadSyllabi('POP2')\">";
} else {
    echo "<body>";
}

It may be beneficial (if you plan on adding more cases) to use a switch statement to make your code more readable.

switch ((isset($_GET['s']) ? $_GET['s'] : '')) {
    case 'jwshxnsyllabus':
        echo "<body onload=\"loadSyllabi('syllabus', '../syllabi/jwshxnporsyllabus.xml',         '../bibliographies/jwshxnbibliography_')\">";
        break;
    case 'aquinas':
        echo "<body onload=\"loadSyllabi('syllabus', '../syllabi/AquinasSyllabus.xml')\">";
        break;
    case 'POP2':
        echo "<body onload=\"loadSyllabi('POP2')\">";
        break;
    default:
        echo "<body>";
        break;
}

EDIT: BTW, the first set of code I wrote mimics what yours is meant to do in it’s entirety. Is the expected outcome of an unexpected value in ?s= meant to output no <body> tag or was this an oversight? Note that the switch will fix this by always defaulting to <body>.

More Related Contents:

  1. What does the PHP error message “Notice: Use of undefined constant” mean?
  2. undefined offset PHP error
  3. Undefined variable problem with PHP function
  4. Notice: Undefined index: HTTP_REFERER
  5. PHP Undefined index error $_FILES?
  6. Undefined index error PHP
  7. How to extract img src, title and alt from html using php? [duplicate]
  8. Forcing to download a file using PHP
  9. How to use store and use session variables across pages?
  10. How to call a function from a string stored in a variable?
  11. Edit PDF en PHP? [closed]
  12. How to show Ajax requests in URL?
  13. PHP check if file is an image [duplicate]
  14. How to access PHP with the Command Line on Windows?
  15. Accessing a class constant using a simple variable which contains the name of the constant
  16. Variable-length lookbehind-assertion alternatives for regular expressions
  17. Best Practices: working with long, multiline strings in PHP?
  18. PHP absolute path to root
  19. PHP: Split multibyte string (word) into separate characters
  20. How to convert text to SVG paths?
  21. What is the difference between PHP require and include?
  22. Overwrite Line in File with PHP
  23. Remove warning messages in PHP
  24. Are the PHP preg_functions multibyte safe?
  25. PHP cURL how to add the User Agent value OR overcome the Servers blocking cURL requests?
  26. foreach with three variables add
  27. Laravel Eloquent: How to get only certain columns from joined tables
  28. check if url exists in php [duplicate]
  29. How to use Laravel Passport with Password Grant Tokens?
  30. CORS: PHP: Response to preflight request doesn’t pass. Am allowing origin

Leave a Comment