Proper way to skip a then function in Q Promises

by

It depends a bit on what the conditions to skip are, what kind of operations you are doing, and how “useful” the whole thing is when the conditions failed. You might be able to use a smart rejection here to bring the message across. Otherwise, I believe the correct way to deal with this is really a nested set of promise calls.

This also matches the core idea behind promises, which is to bring back synchronous control structures to asynchronous code execution. In general, when using promises, you should first think about how you would do the task with synchronous code. And if you think about your situation, it would probably work like this:

var contents = readFromFile();
var results = initialOperation(contents);
if (fancyCondition(results)) {
     results = doSomething(results);
     results = doMore(results);
}
processAndPrint(results);

So you would have a real branch in there in synchronous code. As such, it makes no sense that you would want to avoid that in asynchronous code using promises. If you could just skip things, you were essentially using jumps with gotos. But instead, you branch off and do some other things separately.

So going back to promises and asynchronous code, having an actual branch with another set of chained operations is completely fine, and actual in spirit of the intent behind promises. So above code could look like this:

readFromFile(fileName)
.then(initialOperation)
.then(function (results) {
    if (fancyCondition(results) {
        return doSomething(results)
            .then(doMore);
    }
    return results;
})
.catch(errorHandler)
.then(processResults)
.then(outputResults); // Or `done` in Q

Also note, that the promise pipeline automatically looks a lot more cleaner when you start using functions that return promises on their own, instead of creating them inline from then.

More Related Contents:

  1. Issue in returning data retrieved from DB queries called in the loop
  2. return value after a promise [duplicate]
  3. Why is ‘this’ undefined inside class method when using promises? [duplicate]
  4. Are there still reasons to use promise libraries like Q or BlueBird now that we have ES6 promises? [closed]
  5. What happens if i reject / resolve multiple times in Kriskowal’s q?
  6. javascript promise not passing all arguments (using Q)
  7. How do I convert an existing callback API to promises?
  8. When is .then(success, fail) considered an antipattern for promises?
  9. Is it bad practice to have a constructor function return a Promise?
  10. Resolve promises one after another (i.e. in sequence)?
  11. Correct way to write a non-blocking function in Node.js
  12. Asynchronous exception handling with bluebird promises
  13. Promise Retry Design Patterns
  14. How to sequentially run promises with Q in Javascript?
  15. Handling multiple catches in promise chain
  16. How do I tell if an object is a Promise?
  17. Why do I need to await an async function when it is not supposedly returning a Promise?
  18. Catching Errors in JavaScript Promises with a First Level try … catch
  19. using async await and .then together
  20. Why cant I inline call to res.json?
  21. Promises: Repeat operation until it succeeds?
  22. Why is my function returning Promise { } [duplicate]
  23. Difference of using async / await vs promises?
  24. Javascript Asynchronous Exception Handling with node.js
  25. Produce a promise which depends on recursive promises
  26. Promise.all().then() resolve?
  27. Properly batch nested promises in Node
  28. what happens when a Promise never resolves? [duplicate]
  29. How to return a promise when writestream finishes?
  30. Weird behavior with Promise throwing “Unhandled promise rejection” error

Leave a Comment