Random number in a loop [duplicate]

by

Move the declaration of the random number generator out of the loop.

The random number generation starts from a seed value. If the same seed is used repeatedly, the same series of numbers is generated. One way to produce different sequences is to make the seed value time-dependent, thereby producing a different series with each new instance of Random. By default, the parameterless constructor of the Random class uses the system clock to generate its seed value, …

Source

By having the declaration in the loop you are effectively calling the constructor with the same value over and over again – hence you are getting the same numbers out.

So your code should become:

Random r = new Random();
for ...
    string += r.Next(4);

More Related Contents:

  1. Generate random string from list of string in C#? [closed]
  2. C# Switch Randomized [closed]
  3. Getting same numbers from random number generator even though it’s out of the loop. Why? [closed]
  4. Random.Next returns always the same values [duplicate]
  5. Most efficient way to randomly “sort” (Shuffle) a list of integers in C#
  6. Is C# Random Number Generator thread safe?
  7. Select N random elements from a List in C#
  8. How do I generate a random integer in C#?
  9. Random weighted choice
  10. Unique random string generation
  11. Why does it appear that my random number generator isn’t random in C#?
  12. Produce a random number in a range using C#
  13. Why use the C# class System.Random at all instead of System.Security.Cryptography.RandomNumberGenerator?
  14. Generate N random and unique numbers within a range
  15. Random Numbers in Unity3D?
  16. C# Random Numbers aren’t being “random”
  17. Generating a Random Decimal in C#
  18. How to generate random color names in C#
  19. Random encounter not so random
  20. Non-repetitive random number
  21. Random slot algorithm
  22. Why does Random.Next() always return the same number [duplicate]
  23. Pros and cons of RNGCryptoServiceProvider
  24. Multiple random numbers are the same [duplicate]
  25. Generate random values in C#
  26. Making an array of random ints
  27. How to get random values from array in C# [duplicate]
  28. C# Select random element from List
  29. How to save the state of a Random generator in C#? [duplicate]
  30. Correct way to use Random in multithread application [duplicate]

Leave a Comment