Remove elements of a vector inside the loop

by

You should not increment it in the for loop:

for (vector<Player>::iterator it=allPlayers.begin(); 
                              it!=allPlayers.end(); 
                              /*it++*/) <----------- I commented it.
{

   if(it->getpMoney()<=0) 
      it = allPlayers.erase(it);
  else 
      ++it;
 }

Notice the commented part;it++ is not needed there, as it is getting incremented in the for-body itself.

As for the error “‘operator=” function is unavailable in “Player’“, it comes from the usage of erase() which internally uses operator= to move elements in the vector. In order to use erase(), the objects of class Player must be assignable, which means you need to implement operator= for Player class.

Anyway, you should avoid raw loop1 as much as possible and should prefer to use algorithms instead. In this case, the popular Erase-Remove Idiom can simplify what you’re doing.

allPlayers.erase(
    std::remove_if(
        allPlayers.begin(), 
        allPlayers.end(),
        [](Player const & p) { return p.getpMoney() <= 0; }
    ), 
    allPlayers.end()
);

1. It’s one of the best talks by Sean Parent that I’ve ever watched.

More Related Contents:

  1. Erasing elements from a vector
  2. How do I erase an element from std::vector by index?
  3. C++ Erase vector element by value rather than by position? [duplicate]
  4. Vector.erase(Iterator) causes bad memory access
  5. Erasing vector::end from vector
  6. How to erase & delete pointers to objects stored in a vector?
  7. How to enforce move semantics when a vector grows?
  8. What is the easiest way to initialize a std::vector with hardcoded elements?
  9. Alternative to vector
  10. reduce the capacity of an stl vector
  11. How to sum up elements of a C++ vector?
  12. Finding the centroid of a polygon?
  13. What is the difference between std::array and std::vector? When do you use one over other? [duplicate]
  14. how do you insert the value in a sorted vector?
  15. C++ for-loop – size_type vs. size_t
  16. Bjarne Stroustrup says we must avoid linked lists
  17. Reorder vector using a vector of indices [duplicate]
  18. C++ std::vector vs array in the real world
  19. C++ Remove punctuation from String
  20. Vector that can have 3 different data types C++
  21. c++: can vector contain objects of type Derived?
  22. Why can’t I create a vector of lambdas (of the same type) in C++11?
  23. How to downsize std::vector?
  24. C++ convert vector to vector
  25. Is std::vector memory freed upon a clear?
  26. Getting a vector into a function that expects a vector
  27. How can I get the maximum or minimum value in a vector?
  28. Initializing a ublas vector from a C array
  29. Is it more efficient to copy a vector by reserving and copying, or by creating and swapping? [duplicate]
  30. C++ trying to swap values in a vector

Leave a Comment