ReSharper complains when method can be static, but isn’t

by

I find that comment very useful as it points out two important things:

  1. It makes me ask myself if the method
    in question should actually be part
    of the type or not. Since it doesn’t use
    any instance data, you should at
    least consider if it could be moved
    to its own type. Is it an integral part
    of the type, or is it really a general
    purpose utility method?

  2. If it does make sense to keep the
    method on the specific type, there’s
    a potential performance gain as the
    compiler will emit different code
    for a static method.

More Related Contents:

  1. Method can be made static, but should it?
  2. Virtual member call in a constructor
  3. Access to Modified Closure
  4. What is the difference between a regular string and a verbatim string?
  5. Invert “if” statement to reduce nesting
  6. Handling warning for possible multiple enumeration of IEnumerable
  7. Access to Modified Closure (2)
  8. .NET: Determine the type of “this” class in its static method
  9. LINQ: Not Any vs All Don’t
  10. How do you find all implementations of an interface?
  11. Why does ReSharper want to use ‘var’ for everything? [duplicate]
  12. Performance of static methods vs instance methods
  13. ReSharper Warning – Access to Modified Closure
  14. Can a static method be overridden in C#?
  15. Visual Studio displaying errors even if projects build
  16. ReSharper formatting: align equal operands
  17. String Interpolation vs String.Format
  18. C# Static variables – scope and persistence
  19. How do I generate a constructor from class fields using Visual Studio (and/or ReSharper)?
  20. Is there a way to force a C# class to implement certain static functions?
  21. Test method is inconclusive: Test wasn’t run. Error?
  22. Custom Brace formatting with Resharper
  23. Disable C# 6.0 Support in ReSharper
  24. ReSharper – Possible Null Assignment when using Microsoft.Contracts
  25. What is the difference between static methods in a Non static class and static methods in a static class?
  26. Can I import a static class as a namespace to call its methods without specifying the class name in C#?
  27. Should these arguments be added or removed?
  28. ReSharper conventions for names of event handlers
  29. What are some alternatives to ReSharper? [closed]
  30. Resharper: vars

Leave a Comment