Invert “if” statement to reduce nesting

by

It is not only aesthetic, but it also reduces the maximum nesting level inside the method. This is generally regarded as a plus because it makes methods easier to understand (and indeed, many static analysis tools provide a measure of this as one of the indicators of code quality).

On the other hand, it also makes your method have multiple exit points, something that another group of people believes is a no-no.

Personally, I agree with ReSharper and the first group (in a language that has exceptions I find it silly to discuss “multiple exit points”; almost anything can throw, so there are numerous potential exit points in all methods).

Regarding performance: both versions should be equivalent (if not at the IL level, then certainly after the jitter is through with the code) in every language. Theoretically this depends on the compiler, but practically any widely used compiler of today is capable of handling much more advanced cases of code optimization than this.

More Related Contents:

  1. Virtual member call in a constructor
  2. Access to Modified Closure
  3. What is the difference between a regular string and a verbatim string?
  4. Method can be made static, but should it?
  5. Handling warning for possible multiple enumeration of IEnumerable
  6. Access to Modified Closure (2)
  7. LINQ: Not Any vs All Don’t
  8. How do you find all implementations of an interface?
  9. Why does ReSharper want to use ‘var’ for everything? [duplicate]
  10. ReSharper Warning – Access to Modified Closure
  11. Visual Studio displaying errors even if projects build
  12. ReSharper complains when method can be static, but isn’t
  13. ReSharper formatting: align equal operands
  14. String Interpolation vs String.Format
  15. Is Int32.ToString() culture-specific?
  16. How do I generate a constructor from class fields using Visual Studio (and/or ReSharper)?
  17. Test method is inconclusive: Test wasn’t run. Error?
  18. Resharper’s example code for explaining “Possible multiple enumeration of IEnumerable”
  19. Custom Brace formatting with Resharper
  20. Disable C# 6.0 Support in ReSharper
  21. ReSharper – Possible Null Assignment when using Microsoft.Contracts
  22. Should these arguments be added or removed?
  23. ReSharper conventions for names of event handlers
  24. What are some alternatives to ReSharper? [closed]
  25. Resharper: vars
  26. Program to find prime numbers
  27. Can you get the column names from a SqlDataReader?
  28. How do you remove invalid hexadecimal characters from an XML-based data source prior to constructing an XmlReader or XPathDocument that uses the data?
  29. I want to understand the lambda expression in @Html.DisplayFor(modelItem => item.FirstName)
  30. Is it Linq or Lambda?

Leave a Comment