Should I use public or private variables?

by

private data members are generally considered good because they provide encapsulation.

Providing getters and setters for them breaks that encapsulation, but it’s still better than public data members because there’s only once access point to that data.

You’ll notice this during debugging. If it’s private, you know you can only modify the variable inside the class. If it’s public, you’ll have to search the whole code-base for where it might be modified.

As much as possible, ban getters/setters and make properties private. This follows the principle of information hiding – you shouldn’t care about what properties a class has. It should be self-contained. Of course, in practice this isn’t feasible, and if it is, a design that follows this will be more cluttered and harder to maintain than one that doesn’t.

This is of course a rule of thumb – for example, I’d just use a struct (equivalent with a class with public access) for, say, a simple point class:

struct Point2D
{
   double x;
   double y;
};

More Related Contents:

  1. Which access specifiers will not affect a friend function?
  2. Why should I prefer to use member initialization lists?
  3. Function pointer to member function
  4. When should you use a class vs a struct in C++?
  5. Is there a performance difference between i++ and ++i in C++?
  6. Thou shalt not inherit from std::vector
  7. Why should the “PIMPL” idiom be used? [duplicate]
  8. How to call a parent class function from derived class function?
  9. Is the PIMPL idiom really used in practice?
  10. What is the difference between private and protected members of C++ classes?
  11. Why are unnamed namespaces used and what are their benefits?
  12. What are the differences between struct and class in C++?
  13. Why should I avoid multiple inheritance in C++?
  14. Why can’t a derived class call protected member function in this code?
  15. Why should I use the “using” keyword to access my base class method?
  16. Declaring multiple object pointers on one line causes compiler error
  17. C++ getters/setters coding style
  18. Implementing multiple interfaces in c++
  19. What is abstraction in C#? [duplicate]
  20. Will an ’empty’ constructor or destructor do the same thing as the generated one?
  21. Diamond inheritance (C++)
  22. overloading base class method in derived class
  23. Semicolon after class declaration braces
  24. Best method for storing this pointer for use in WndProc
  25. How to initialize the reference member variable of a class?
  26. Making a vector of instances of different subclasses
  27. How to create class objects dynamically?
  28. What is the purpose of forward declaration?
  29. Why should I prefer to use member initializer lists?
  30. What does slicing mean in C++?

Leave a Comment