Should objects delete themselves in C++?

by

You have made Update a virtual function, suggesting that derived classes may override the implementation of Update. This introduces two big risks.

1.) An overridden implementation may remember to do a World.Remove, but may forget the delete this. The memory is leaked.

2.) The overridden implementation calls the base-class Update, which does a delete this, but then proceeds with more work, but with an invalid this-pointer.

Consider this example:

class WizardsFire: public Fire
{
public:
    virtual void Update()
    {
        Fire::Update();  // May delete the this-object!
        RegenerateMana(this.ManaCost); // this is now invaild!  GPF!
    }
}

More Related Contents:

  1. Is “delete this” allowed in C++?
  2. When should you use a class vs a struct in C++?
  3. Is there a performance difference between i++ and ++i in C++?
  4. How do malloc() and free() work?
  5. Is delete[] equal to delete?
  6. C++ new int[0] — will it allocate memory?
  7. How to call a parent class function from derived class function?
  8. Is the PIMPL idiom really used in practice?
  9. What is the difference between private and protected members of C++ classes?
  10. How could pairing new[] with delete possibly lead to memory leak only?
  11. Compelling examples of custom C++ allocators?
  12. How to get available memory C++/g++?
  13. How does a C++ reference look, memory-wise?
  14. Any reason to overload global new and delete?
  15. Are memory leaks “undefined behavior” class problem in C++?
  16. Why can’t a derived class call protected member function in this code?
  17. Implementing multiple interfaces in c++
  18. Check if a pointer points to allocated memory on the heap
  19. What is the behavior of “delete” with stack objects? [duplicate]
  20. overloading base class method in derived class
  21. Reason why not to have a DELETE macro for C++
  22. Why, really, deleting an incomplete type is undefined behaviour?
  23. What is “bit padding” or “padding bits” exactly?
  24. How do I call the original “operator new” if I have overloaded it?
  25. How to alloc a executable memory buffer?
  26. Should I use public or private variables?
  27. How to initialize the reference member variable of a class?
  28. How to check memory allocation failures with new operator?
  29. Memory-efficient C++ strings (interning, ropes, copy-on-write, etc) [closed]
  30. C++ is it necessary to delete dynamically allocated objects at the end of the main scope?

Leave a Comment