Singleton instance declared as static variable of GetInstance method, is it thread-safe? [duplicate]

by

In C++11 it is thread safe:

ยง6.7 [stmt.dcl] p4 If control enters the declaration concurrently while the variable is being initialized, the concurrent execution shall wait for completion of the initialization.

In C++03:

  • Under g++ it is thread safe.
    But this is because g++ explicitly adds code to guarantee it.

One problem is that if you have two singletons and they try and use each other during construction and destruction.

Read this:
Finding C++ static initialization order problems

A variation on this problem is if the singleton is accessed from the destructor of a global variable. In this situation the singleton has definitely been destroyed, but the get method will still return a reference to the destroyed object.

There are ways around this but they are messy and not worth doing. Just don’t access a singleton from the destructor of a global variable.

A Safer definition but ugly:
I am sure you can add some appropriate macros to tidy this up

SomeBaseClass &SomeClass::GetInstance()
{
#ifdef _WIN32 
Start Critical Section Here
#elif  defined(__GNUC__) && (__GNUC__ > 3)
// You are OK
#else
#error Add Critical Section for your platform
#endif

    static SomeClass instance;

#ifdef _WIN32
END Critical Section Here
#endif 

    return instance;
}

More Related Contents:

  1. C++ Singleton design pattern
  2. Singleton: How should it be used
  3. How is Meyers’ implementation of a Singleton actually a Singleton
  4. Can any one provide me a sample of Singleton in c++?
  5. Problems with Singleton Pattern
  6. Difference between list<Observer*>* and list<Observer*> in C++ [closed]
  7. How to implement the factory method pattern in C++ correctly
  8. Can we increase the re-usability of this key-oriented access-protection pattern?
  9. Unity singleton manager classes
  10. What is Proxy Class in C++
  11. Is this key-oriented access-protection pattern a known idiom?
  12. How to implement serialization in C++
  13. How to implement multithread safe singleton in C++11 without using
  14. Singleton by Jon Skeet clarification
  15. efficient thread-safe singleton in C++
  16. C++ singleton vs. global static object
  17. Generating an interface without virtual functions?
  18. clean C++ granular friend equivalent? (Answer: Attorney-Client Idiom)
  19. Practical Uses for the “Curiously Recurring Template Pattern”
  20. getting db connection through singleton class
  21. friend class with limited access
  22. How to automatically register a class on creation
  23. Is it bad practice to allocate memory in a DLL and give a pointer to it to a client app?
  24. Singleton pattern in C++
  25. Memory management patterns in C++
  26. Singleton with parameters
  27. How to name this key-oriented access-protection pattern?
  28. Decorator pattern in C++
  29. Double dispatch/multimethods in C++
  30. Multiple instances of singleton across shared libraries on Linux

Leave a Comment