Weird MSC 8.0 error: “The value of ESP was not properly saved across a function call…”

by

This debug error means that the stack pointer register is not returned to its original value after the function call, i.e. that the number of pushes before the function call were not followed by the equal number of pops after the call.

There are 2 reasons for this that I know (both with dynamically loaded libraries). #1 is what VC++ is describing in the error message, but I don’t think this is the most often cause of the error (see #2).

1) Mismatched calling conventions:

The caller and the callee do not have a proper agreement on who is going to do what. For example, if you’re calling a DLL function that is _stdcall, but you for some reason have it declared as a _cdecl (default in VC++) in your call. This would happen a lot if you’re using different languages in different modules etc.

You would have to inspect the declaration of the offending function, and make sure it is not declared twice, and differently.

2) Mismatched types:

The caller and the callee are not compiled with the same types. For example, a common header defines the types in the API and has recently changed, and one module was recompiled, but the other was not–i.e. some types may have a different size in the caller and in the callee.

In that case, the caller pushes the arguments of one size, but the callee (if you’re using _stdcall where the callee cleans the stack) pops the different size. The ESP is not, thus, returned to the correct value.

(Of course, these arguments, and others below them, would seem garbled in the called function, but sometimes you can survive that without a visible crash.)

If you have access to all the code, simply recompile it.

More Related Contents:

  1. What are the different calling conventions in C/C++ and what do each mean?
  2. Difference in performance between MSVC and GCC for highly optimized matrix multplication code
  3. Address of function is not actual code address
  4. how to specify vc11 lambda calling convention
  5. Why does integer overflow on x86 with GCC cause an infinite loop?
  6. Why does this function push RAX to the stack as the first operation?
  7. Will new return NULL in any case?
  8. When should I use _mm_sfence _mm_lfence and _mm_mfence
  9. Convert CString to const char*
  10. Change floating point rounding mode
  11. When and how to use GCC’s stack protection feature?
  12. What is the meaning and usage of __stdcall?
  13. Why does VS not define the alternative tokens for logical operators?
  14. Do current x86 architectures support non-temporal loads (from “normal” memory)?
  15. Why aren’t static const floats allowed? [duplicate]
  16. Is std::string size() a O(1) operation?
  17. DLL References in Visual C++
  18. What are near, far and huge pointers?
  19. Understanding stack frame of function call in C/C++? [closed]
  20. Exception Error c0000005 in VC++
  21. Does this type of memory get allocated on the heap or the stack?
  22. How to test if preprocessor symbol is #define’d but has no value?
  23. Double delete in initializer_list vs 2013
  24. How do YOU reduce compile time, and linking time for Visual C++ projects (native C++)?
  25. LNK2038: mismatch detected for ‘RuntimeLibrary’: value ‘MT_StaticRelease’ doesn’t match value ‘MD_DynamicRelease’ in file.obj
  26. C++ Memory Barriers for Atomics
  27. How can I see the output of the Visual C++ preprocessor? [duplicate]
  28. How to erase & delete pointers to objects stored in a vector?
  29. __attribute__((format(printf, 1, 2))) for MSVC?
  30. How do I find the current directory?

Leave a Comment