What are good candidates for base controller class in ASP.NET MVC?

by

There are no good uses of a base controller class.

Now hear me out.

Asp.Net MVC, especially MVC 3 has tons of extensibility hooks that provide a more decoupled way to add functionality to all controllers. Since your controllers classes are very important and central to an application its really important to keep them light, agile and loosely coupled to everything else.

  • Logging infrastructure belongs in a
    constructor and should be injected
    via a DI framework.

  • CRUD scaffolding should be handled by
    code generation or a custom
    ModelMetadata provider.

  • Global exception handling should be
    handled by an custom ActionInvoker.

  • Global view data and authorization
    should be handled by action filters.
    Even easier with Global action filters
    in MVC3.

  • Constants can go in another class/file called ApplicationConstants or something.

Base Controllers are usually used by inexperienced MVC devs who don’t know all the different extensibility pieces of MVC. Now don’t get me wrong, I’m not judging and work with people who use them for all the wrong reasons. Its just experience that provides you with more tools to solve common problems.

I’m almost positive there isn’t a single problem you can’t solve with another extensibility hook than a base controller class. Don’t take on the the tightest form of coupling ( inheritance ) unless there is a significant productivity reason and you don’t violate Liskov. I’d much rather take the < 1 second to type out a property 20 times across my controllers like public ILogger Logger { get; set; } than introduce a tight coupling which affects the application in much more significant ways.

Even something like a userId or a multitenant key can go in a ControllerFactory instead of a base controller. The coupling cost of a base controller class is just not worth it.

More Related Contents:

  1. Can we pass model as a parameter in RedirectToAction?
  2. Real example of TryUpdateModel, ASP .NET MVC 3
  3. ASP.NET MVC – Should business logic exist in controllers?
  4. Allow multiple roles to access controller action
  5. How to pass parameters to a partial view in ASP.NET MVC?
  6. ASP.NET MVC Programmatically Get a List of Controllers
  7. Having troubles calling a Controller Post Method
  8. Submitting form and pass data to controller method of type FileStreamResult
  9. change controller name convention in ASP.NET MVC
  10. post and get with same method signature
  11. How to determine if using MVC4 vs MVC5 vs MVC6? [closed]
  12. Why does Html.ActionLink render “?Length=4”
  13. jqgrid + EF + MVC: How to export in excel? Which method you suggest?
  14. Date only from TextBoxFor()
  15. One DbContext per request in ASP.NET MVC (without IOC container)
  16. Custom DateTime model binder in Asp.net MVC
  17. How to Render Partial View into a String
  18. ASP.NET MVC partial views: input name prefixes
  19. Using MVC HtmlHelper extensions from Razor declarative views
  20. attribute dependent on another field
  21. Mocking HttpContextBase with Moq
  22. How can I load Partial view inside the view?
  23. Access email address in the OAuth ExternalLoginCallback from Facebook v2.4 API in ASP.NET MVC 5 [duplicate]
  24. How to specify an area name in an action link?
  25. How do you mock the session object collection using Moq
  26. Html5 data-* with asp.net mvc TextboxFor html attributes
  27. MVC 4 ignores DefaultModelBinder.ResourceClassKey
  28. Working with the Output Cache and other Action Filters
  29. Load PartialView with using jquery Ajax?
  30. MVC Forms LoginUrl is incorrect

Leave a Comment