ASP.NET MVC – Should business logic exist in controllers?

by

Business logic should really be in the model. You should be aiming for fat models, skinny controllers.

For example, instead of having:

public interface IOrderService{
    int CalculateTotal(Order order);
}

I would rather have:

public class Order{
    int CalculateTotal(ITaxService service){...}        
}

This assumes that tax is calculate by an external service, and requires your model to know about interfaces to your external services.

This would make your controller look something like:

public class OrdersController{
    public OrdersController(ITaxService taxService, IOrdersRepository ordersRepository){...}

    public void Show(int id){
        ViewData["OrderTotal"] = ordersRepository.LoadOrder(id).CalculateTotal(taxService);
    }
}

Or something like that.

More Related Contents:

  1. What are good candidates for base controller class in ASP.NET MVC?
  2. Can we pass model as a parameter in RedirectToAction?
  3. Real example of TryUpdateModel, ASP .NET MVC 3
  4. Where to place AutoMapper.CreateMaps?
  5. Allow multiple roles to access controller action
  6. How to pass parameters to a partial view in ASP.NET MVC?
  7. ASP.NET MVC Programmatically Get a List of Controllers
  8. Having troubles calling a Controller Post Method
  9. Submitting form and pass data to controller method of type FileStreamResult
  10. MVVM ViewModel vs. MVC ViewModel
  11. change controller name convention in ASP.NET MVC
  12. post and get with same method signature
  13. Set Culture in an ASP.Net MVC app
  14. CheckboxList in MVC3 View and get the checked items passed to the controller
  15. Uploadify (Session and authentication) with ASP.NET MVC
  16. How to use Ajax.ActionLink?
  17. How to force ASP.NET Web API to always return JSON?
  18. How to disable a global filter in ASP.Net MVC selectively
  19. HTTP Error 403.14 – Forbidden The Web server is configured to not list the contents
  20. Stream file using ASP.NET MVC FileContentResult in a browser with a name?
  21. Where can I find a list of escape characters required for my JSON ajax return type?
  22. MVC Html.Partial or Html.Action
  23. Bootstrap glyphicon not showing in Form
  24. Where to run a duplicate check for an entity
  25. Attempt by security transparent method ‘WebMatrix.WebData.PreApplicationStartCode.Start()’
  26. ASP.Net MVC and state – how to keep state between requests
  27. How to replace the default ModelState error message in Asp.net MVC 2?
  28. ASP.net MVC support for URL’s with hyphens
  29. MVC DropDownList SelectedValue not displaying correctly
  30. How can I RedirectToAction within $.ajax callback?

Leave a Comment