Why is program not compiling? [closed]

by

Taking that and compiling it gives me the simple error:

fatal error: iostream.h: No such file or directory

This is self-explanatory. The reason is that <iostream> doesn’t have an extension, or a .h equivalent. Change the line to:

#include <iostream>

Proof that it compiles (not including the following points, but removing things irrelevant to ideone): http://ideone.com/WIDjR

Aside from that:

  • You don’t need windows.h. system is part of cstdlib.

  • using namespace std; often does more bad than good. It’s recommended to stick to std::cout etc. Inside main isn’t the worst place it could be, but nonetheless, not a great habit to get into.

  • if( number >= 2 && number <= 2 ) is a logic error, both in writing and execution. The simpler form would be if (number == 2), but the correct form, based on your output, would be if (number != 2), lest every number other than 2 is the right guess.

  • system ("PAUSE") is bad. You don’t know if pause.exe will do that, or if it will even exist. Someone could have a pause.exe that formats their hard drive, and you’d be to blame for executing it. Use a form of cin.get(), or, if your compiler implements it to clear the input buffer, cin.sync(); cin.get(); for consistent behaviour. Beware that cin.sync()‘s behaviour is not guaranteed.

  • Your program should be returning 0 from normal exit. Anything else is taken to mean an error occurred. return 0; in main is implicit if you don’t specify a return value.

More Related Contents:

  1. Absolute Distinct Numbers
  2. Sorting a vector of custom objects
  3. What is a nondeduced context?
  4. What is the difference between new/delete and malloc/free?
  5. Returning multiple values from a C++ function
  6. Function with same name but different signature in derived class
  7. Operator< and strict weak ordering
  8. How do I add a linker or compile flag in a CMake file?
  9. C++ “virtual” keyword for functions in derived classes. Is it necessary?
  10. Reading and writing binary file
  11. Integer to hex string in C++
  12. C++ static polymorphism (CRTP) and using typedefs from derived classes
  13. What does casting to `void` really do? [duplicate]
  14. Removing item from vector, while in C++11 range ‘for’ loop?
  15. (-2147483648> 0) returns true in C++?
  16. Exporting classes containing `std::` objects (vector, map etc.) from a DLL
  17. Is there a __CLASS__ macro in C++?
  18. Is it worth setting pointers to NULL in a destructor?
  19. Why are my struct’s members not properly initialised using `{}`? [duplicate]
  20. Default class inheritance access
  21. How can I sort a std::map first by value, then by key?
  22. questions about name mangling in C++
  23. Can I download the Visual C++ Command Line Compiler without Visual Studio?
  24. Why is it that we can write outside of bounds in C?
  25. What encoding does std::string.c_str() use?
  26. STL analogue in Fortran
  27. Using shared_ptr in dll-interfaces
  28. Call C++ code from MATLAB?
  29. const in C vs const in C++
  30. #ifdef vs #if – which is better/safer as a method for enabling/disabling compilation of particular sections of code?

Leave a Comment