Are there gotchas using varargs with reference parameters

by

If you look at what va_start expands out to, you’ll see what’s happening:

va_start(argptr, format);

becomes (roughly)

argptr = (va_list) (&format+1);

If format is a value-type, it gets placed on the stack right before all the variadic arguments. If format is a reference type, only the address gets placed on the stack. When you take the address of the reference variable, you get the address or the original variable (in this case of a temporary AnsiString created before calling Broken), not the address of the argument.

If you don’t want to pass around full classes, your options are to either pass by pointer, or put in a dummy argument:

AnsiString working_ptr(const AnsiString *format,...)
{
    ASSERT(format != NULL);
    va_list argptr;
    AnsiString buff;

    va_start(argptr, format);
    buff.vprintf(format->c_str(), argptr);

    va_end(argptr);
    return buff;
}

...

AnsiString format = "Hello %s";
s1 = working_ptr(&format, "World");

or

AnsiString working_dummy(const AnsiString &format, int dummy, ...)
{
    va_list argptr;
    AnsiString buff;

    va_start(argptr, dummy);
    buff.vprintf(format.c_str(), argptr);

    va_end(argptr);
    return buff;
}

...

s1 = working_dummy("Hello %s", 0, "World");

More Related Contents:

  1. What does the following return type actually mean
  2. Why ‘&’ reference in not required in classes in C++?
  3. What are the differences between a pointer variable and a reference variable in C++?
  4. What is a reference variable in C++?
  5. Should I prefer pointers or references in member data?
  6. Reason to Pass a Pointer by Reference in C++?
  7. C++ pass an array by reference
  8. Can we reassign the reference in C++?
  9. C++ standard: dereferencing NULL pointer to get a reference? [duplicate]
  10. int vs const int& [closed]
  11. Is null reference possible?
  12. Why does printf() promote a float to a double?
  13. trailing return type using decltype with a variadic template function
  14. What are the differences between a pointer variable and a reference variable?
  15. What default promotions of types are there in the variadic arguments list?
  16. Passing references to pointers in C++
  17. Is it safe to push_back an element from the same vector?
  18. ampersand (&) at the end of variable etc
  19. error: invalid initialization of non-const reference of type ‘int&’ from an rvalue of type ‘int’
  20. Technically, how do variadic functions work? How does printf work?
  21. Declare a reference and initialize later?
  22. What is the difference between std::reference_wrapper and a simple pointer?
  23. Returning const reference to local variable from a function
  24. What is a constant reference? (not a reference to a constant)
  25. Why can’t I initialize a reference in an initializer list with uniform initialization?
  26. dereferencing a pointer when passing by reference
  27. What is the proper way to return an object from a C++ function?
  28. Reference to a pointer
  29. Literal initialization for const references
  30. Both asterisk and ampersand in a parameter

Leave a Comment