Assign variable in if condition statement, good practice or not? [closed]

by

I wouldn’t recommend it. The problem is, it looks like a common error where you try to compare values, but use a single = instead of == or ===. For example, when you see this:

if (value = someFunction()) {
    ...
}

you don’t know if that’s what they meant to do, or if they intended to write this:

if (value == someFunction()) {
    ...
}

If you really want to do the assignment in place, I would recommend doing an explicit comparison as well:

if ((value = someFunction()) === <whatever truthy value you are expecting>) {
    ...
}

More Related Contents:

  1. How can select specific text value from <select> <option…? [closed]
  2. How to get word that is after indexOf(“@”) and add it to array
  3. How to check if a string “StartsWith” another string?
  4. Using Node.js require vs. ES6 import/export
  5. How to turn a String into a JavaScript function call? [duplicate]
  6. JS Client-Side Exif Orientation: Rotate and Mirror JPEG Images
  7. detect back button click in browser [duplicate]
  8. Get time difference between two dates in seconds
  9. Lodash – difference between .extend() / .assign() and .merge()
  10. JavaScript object literals syntax error
  11. Using raw image data from ajax request for data URI
  12. Replace all spaces in a string with ‘+’ [duplicate]
  13. Use a concatenated (dynamic) string as JavaScript object key? [duplicate]
  14. JSON.stringify deep objects
  15. Simplest way to detect a pinch
  16. “Origin null is not allowed by Access-Control-Allow-Origin” in Chrome. Why? [duplicate]
  17. Avoid window jump to top when clicking #-links
  18. Do I need to remove event listeners before removing elements?
  19. What is the right way to make a synchronous MongoDB query in Node.js?
  20. How to pass state back to parent in React?
  21. Is it possible to append a div inside an SVG element? [duplicate]
  22. TypeScript enum to object array
  23. jQuery .on() method doesn’t see new elements
  24. Passing parameters to a JQuery function
  25. set withCredentials to the new ES6 built-in HTTP request API : Fetch
  26. jQuery: Check if special characters exists in string
  27. What’s different between Python and Javascript regular expressions?
  28. How to prevent an iframe from reloading when moving it in the DOM
  29. How does JavaScript import find the module without an extension?
  30. What happens when promise is yielded in javascript?

Leave a Comment