“borrowed value does not live long enough” seems to blame the wrong thing

by

is pointing the blame at l

It’s not, really. Review the error message again:

     for w in l.unwrap().split_whitespace() {
              ---------- temporary value created here

The error marker is pointing to the call of unwrap on l.

when the issue is w

It’s not, really. l is of type Result<String>. When you call unwrap, you get a String, and then split_whitespace returns references to that string. These references live only as long as the string, but your code tries to put them into a hashmap that will live longer than the string. The problem is that the l.unwrap() doesn’t live long enough, and w is just a reference to the thing that doesn’t live long enough.

Conceptually, it’s the same problem as this code:

use std::collections::HashMap;

fn main() {
    let mut counts = HashMap::new();

    {
        let s = String::from("hello world");
        counts.insert(&s, 0);
    }

    println!("{:?}", counts);
}

Which also points to s and says it doesn’t live long enough (because it doesn’t).

The correct solution is to convert each word into an owned String which the HashMap can then hold:

for l in reader.lines() {
    for w in l.unwrap().split_whitespace() {
        counts.entry(w.to_string()).or_insert(0) += 1;
    }
}

More Related Contents:

  1. What are non-lexical lifetimes?
  2. How can I include a module from another file from the same project?
  3. What does “Sized is not implemented” mean?
  4. Deriving a trait results in unexpected compiler error, but the manual implementation works
  5. How do I implement Copy and Clone for a type that contains a String (or any type that doesn’t implement Copy)?
  6. Mutably borrow one struct field while borrowing another in a closure
  7. How do I convert a Vector of bytes (u8) to a string?
  8. When is it useful to define multiple lifetimes in a struct?
  9. Can I write an Iterator that mutates itself and then yields a reference into itself?
  10. How to update-or-insert on a Vec?
  11. Lifetime troubles sharing references between threads
  12. Moved variable still borrowing after calling `drop`?
  13. How do I include the end value in a range?
  14. “expected type parameter, found struct”
  15. Adding an append method to a singly linked list
  16. How do you set, clear and toggle a single bit in Rust?
  17. Lifetime of variables passed to a new thread
  18. How can I co-sort two Vecs based on the values in one of the Vecs?
  19. How can I distinguish between a deserialized field that is missing and one that is null?
  20. Cannot create a generic function that uses a literal zero
  21. Is there a way to combine multiple traits in order to define a new trait? [duplicate]
  22. How to avoid temporary allocations when using a complex key for a HashMap?
  23. Why does compilation not fail when a member of a moved value is assigned to?
  24. Why does a mutable borrow of a closure through DerefMut not work?
  25. What does “missing lifetime specifier” mean when storing a &str in a structure?
  26. Why can Serde not derive Deserialize for a struct containing only a &Path?
  27. What is the purpose of the unit type in Rust?
  28. Why does the Rust compiler request I constrain a generic type parameter’s lifetime (error E0309)?
  29. Cannot pass self as callback parameter due to double borrowing
  30. How do I create a HashMap with type erased keys?

Leave a Comment