exit() call inside a function which should return a reference

by

This situation is so bad that the program cannot continue, so I print a message to help to spot the bug and call exit(1)

No. If this code is part of a library, the library should not be the one deciding if the application should exit or not.

What if a file is open and needs to be closed, or some other resource needs to be cleaned up, or if the user of your DB class wants to log the error and continue doing something else?

The answer is anything but what you’re doing now. Throw an exception, return an error code, etc. but don’t close the application down within library or class code.

Believe it or not, there was a commercial DB library that did exactly what you’re doing (closing the app down). They got a lot of angry responses from users of their library as to why they’re shutting the application down unexpectedly. And you know what — the answer given to the customers was that “we felt the error was severe enough to stop the application, because our library can’t continue to work properly”. That is not only bad reasoning, it borders on arrogance, and the customers let them know that.

More Related Contents:

  1. How to “return an object” in C++?
  2. return statement vs exit() in main()
  3. What does the following return type actually mean
  4. Why ‘&’ reference in not required in classes in C++?
  5. Possibilities to quit a function
  6. What are the differences between a pointer variable and a reference variable in C++?
  7. Should I prefer pointers or references in member data?
  8. Reason to Pass a Pointer by Reference in C++?
  9. C++ pass an array by reference
  10. C++ standard: dereferencing NULL pointer to get a reference? [duplicate]
  11. int vs const int& [closed]
  12. Is null reference possible?
  13. What are the differences between a pointer variable and a reference variable?
  14. Is it safe to push_back an element from the same vector?
  15. ampersand (&) at the end of variable etc
  16. Declare a reference and initialize later?
  17. What is the difference between std::reference_wrapper and a simple pointer?
  18. Returning const reference to local variable from a function
  19. Are there gotchas using varargs with reference parameters
  20. What is a constant reference? (not a reference to a constant)
  21. return statement in ternary operator c++
  22. Why can’t I initialize a reference in an initializer list with uniform initialization?
  23. Why do some people prefer “T const&” over “const T&”?
  24. Why Can’t I store references in a `std::map` in C++?
  25. Are destructors run when calling exit()? [duplicate]
  26. Why does std::forward have two overloads?
  27. Why we need to return reference to istream/ostream while overloading >> and
  28. Why is a c++ reference considered safer than a pointer?
  29. Is it safe to make a const reference member to a temporary variable?
  30. Pass by pointer & Pass by reference [duplicate]

Leave a Comment