Fix warning “Capturing [an object] strongly in this block is likely to lead to a retain cycle” in ARC-enabled code

by

Replying to myself:

My understanding of the documentation says that using keyword block and setting the variable to nil after using it inside the block should be ok, but it still shows the warning.

__block ASIHTTPRequest *request = [[ASIHTTPRequest alloc] initWithURL:...

[request setCompletionBlock:^{
    NSDictionary *jsonDictionary = [[CJSONDeserializer deserializer] deserialize:request.responseData error:nil];
    request = nil;
// ....

    }];

Update: got it to work with the keyword ‘_weak’ instead of ‘_block’, and using a temporary variable:

ASIHTTPRequest *_request = [[ASIHTTPRequest alloc] initWithURL:...
__weak ASIHTTPRequest *request = _request;

[request setCompletionBlock:^{
    NSDictionary *jsonDictionary = [[CJSONDeserializer deserializer] deserialize:request.responseData error:nil];
    // ...
    }];

If you want to also target iOS 4, use __unsafe_unretained instead of __weak. Same behavior, but the pointer stays dangling instead of being automatically set to nil when the object is destroyed.

More Related Contents:

  1. capturing self strongly in this block is likely to lead to a retain cycle
  2. With ARC, what’s better: alloc or autorelease initializers?
  3. Ignoring certificate errors with NSURLConnection
  4. Xcode – How to fix ‘NSUnknownKeyException’, reason: … this class is not key value coding-compliant for the key X” error?
  5. @class vs. #import
  6. How to Check if an NSDate occurs between two other NSDates
  7. @synthesize vs @dynamic, what are the differences?
  8. Which should I use, -awakeFromNib or -viewDidLoad?
  9. What is the entry point of swift code execution?
  10. Non-English default language for iOS App?
  11. Changing the userAgent of NSURLConnection
  12. NSArray Equivalent of Map
  13. Can I edit the pixels of the UIImage’s property CGImage
  14. UIButton Touch and Hold
  15. How to write a simple Ping method in Cocoa/Objective-C
  16. KVO and ARC how to removeObserver
  17. Number of Occurrences of a Character in NSString
  18. NSString to NSArray
  19. Is there a decent OpenGL text drawing library for the iPhone SDK?
  20. Removing duplicates from NSMutableArray
  21. How to create backBarButtomItem with custom view for a UINavigationController
  22. Call instance method from class method
  23. Using MD5 hash on a string in cocoa? [duplicate]
  24. Couldn’t UIToolBar be transparent?
  25. WWDC 2010 Sample Code [closed]
  26. What does the NS prefix mean?
  27. What are the numbers in the square brackets in NSLog() output?
  28. Xcode ARC (automatic reference counting), “release is unavailable”
  29. What’s the difference between [NSNull null] and nil?
  30. +[NSString stringWithString:] — what’s the point?

Leave a Comment