I can’t get his implementation of Merge Sort right. Debug it

by

I got it guys 🙂
While copying main array into auxiliary array in the Merge function, there was bug in the index.

int size = hi - lo + 1;
    int *aux_arr = new int[size];
    for(i = 0, j = lo;i <= size;i++){
        aux_arr[i] = first_arr[j++];
    }

Here’s the code with correction.
Also as the auxiliary array index starts from 0 to the size, I’ll have to change the index in the final merging loop

i = 0, j = mid - lo + 1;
    for(k = lo;k <= hi;k++){
        if(i > mid - lo) first_arr[k] = aux_arr[j++];
        else if(j > hi - lo) first_arr[k] = aux_arr[i++];
        else if(aux_arr[i] < aux_arr[j]) first_arr[k] = aux_arr[i++];
        else first_arr[k] = aux_arr[j++];
    }

Rest will remain same.
Thanks for commenting, it really helped. 🙂

More Related Contents:

  1. C++ : Unable to read from large txt file [closed]
  2. `std::list::sort()` – why the sudden switch to top-down strategy?
  3. Questions regarding constructors
  4. Storing C++ template function definitions in a .CPP file
  5. What happens if I define a 0-size array in C/C++?
  6. Why is enum class preferred over plain enum?
  7. Why should I not include cpp files and instead use a header?
  8. In this specific case, is there a difference between using a member initializer list and assigning values in a constructor?
  9. print call stack in C or C++
  10. Have you used any of the C++ interpreters (not compilers)? [closed]
  11. Isn’t the template argument (the signature) of std::function part of its type?
  12. Using a STL map of function pointers
  13. The simplest and neatest c++11 ScopeGuard
  14. Using float gives “call to overloaded function is ambiguous” error [duplicate]
  15. Find out whether a C++ object is callable
  16. Why would someone use #define to define constants?
  17. Function Overloading Based on Value vs. Const Reference
  18. Why do we need to use boost::asio::io_service::work?
  19. why reference size is always 4 bytes – c++
  20. How to use graphics.h in codeblocks?
  21. Does boost have a datatype for set operations that is simpler than the STL?
  22. Using `std::function` to call non-void function
  23. Using std::string_view with api that expects null-terminated string
  24. For loop prints an extra comma
  25. Check if a type is from a particular namespace
  26. Difference between a C++ exception and Structured Exception
  27. Understanding -Weffc++
  28. Advantages of using initializer list? [duplicate]
  29. Is lambdification of a concept an improvement or bad practice?
  30. Why can’t C++11 move a noncopyable functor to a std::function?

Leave a Comment