Resharper’s example code for explaining “Possible multiple enumeration of IEnumerable”

by

GetNames() returns an IEnumerable. So if you store that result:

IEnumerable foo = GetNames();

Then every time you enumerate foo, the GetNames() method is called again (not literally, I can’t find a link that properly explains the details, but see IEnumerable.GetEnumerator()).

Resharper sees this, and suggests you to store the result of enumerating GetNames() in a local variable, for example by materializing it in a list:

IEnumerable fooEnumerated = GetNames().ToList();

This will make sure that the GetNames() result is only enumerated once, as long as you refer to fooEnumerated.

This does matter because you usually want to enumerate only once, for example when GetNames() performs a (slow) database call.

Because you materialized the results in a list, it doesn’t matter anymore that you enumerate fooEnumerated twice; you’ll be iterating over an in-memory list twice.

More Related Contents:

  1. Virtual member call in a constructor
  2. Access to Modified Closure
  3. What is the difference between a regular string and a verbatim string?
  4. Method can be made static, but should it?
  5. Invert “if” statement to reduce nesting
  6. Handling warning for possible multiple enumeration of IEnumerable
  7. Access to Modified Closure (2)
  8. ReSharper “Cannot resolve symbol” even when project builds
  9. LINQ: Not Any vs All Don’t
  10. How do you find all implementations of an interface?
  11. Why does ReSharper want to use ‘var’ for everything? [duplicate]
  12. ReSharper Warning – Access to Modified Closure
  13. Visual Studio displaying errors even if projects build
  14. ReSharper complains when method can be static, but isn’t
  15. ReSharper formatting: align equal operands
  16. String Interpolation vs String.Format
  17. Is Int32.ToString() culture-specific?
  18. How do I generate a constructor from class fields using Visual Studio (and/or ReSharper)?
  19. Test method is inconclusive: Test wasn’t run. Error?
  20. Custom Brace formatting with Resharper
  21. Disable C# 6.0 Support in ReSharper
  22. ReSharper – Possible Null Assignment when using Microsoft.Contracts
  23. Should these arguments be added or removed?
  24. ReSharper conventions for names of event handlers
  25. What are some alternatives to ReSharper? [closed]
  26. Resharper: vars
  27. Using JsonConvert.DeserializeObject to deserialize Json to a C# POCO class
  28. Pass array to mvc Action via AJAX
  29. How to interrupt Console.ReadLine
  30. Active Directory (LDAP) – Check account locked out / Password expired

Leave a Comment