Javascript document write overwriting page?

by

Using document.write() after the page has finished loading implicitly calls document.open(), which creates a new page. You should generally avoid document.write() and stick to proper DOM creation techniques, or use jQuery’s shorthand creation methods:

jQuery(function($) {
    $('<style type="text/css"> .preload img { display: none; } </style>')
        .appendTo("head");
    $('#body-wrap').preloadThis();
});

I’m assuming you can’t edit the HTML or CSS files that are loaded by the page to include this rule? If that’s the case, and you want these styles applied before the page finishes loading, take `document.write()` out of the jQuery ready handler:

// write() before the document finishes loading
document.write('<style type="text/css"> .preload img { display: none; } </style>');
jQuery(function($) {
    $('#body-wrap').preloadThis();
});

This will write the <style> tag immediately after the currently executing <script> tag. Hopefully, this is in your <head> element as <style> is invalid anywhere else, although all browsers should parse it OK either way.

More Related Contents:

  1. When is JavaScript’s eval() not evil?
  2. What is the purpose of wrapping whole Javascript files in anonymous functions like “(function(){ … })()”?
  3. What’s the best way to convert a number to a string in JavaScript?
  4. Declaring multiple variables in JavaScript
  5. JavaScript: What dangers are in extending Array.prototype?
  6. How can I set multiple CSS styles in JavaScript?
  7. style.display=’none’ doesn’t work on option tags in chrome, but it does in firefox
  8. typeof !== “undefined” vs. != null
  9. Unobtrusive JavaScript: at the top or the bottom of the HTML code?
  10. What does this “(function(){});”, a function inside brackets, mean in javascript? [duplicate]
  11. JavaScript braces on new line or not? [closed]
  12. Is there a better way of writing v = (v == 0 ? 1 : 0); [closed]
  13. Why use semicolon? [duplicate]
  14. What is “?:” notation in JavaScript?
  15. setTimeout() with string or (anonymous) function reference? speedwise [closed]
  16. Are there any coding standards for JavaScript? [closed]
  17. JavaScript style for optional callbacks
  18. JavaScript: inline functions vs predefined functions
  19. XSS attacks and style attributes
  20. How can I programmatically copy all of the style attributes from one DOM element to another
  21. State not updating when using React state hook within setInterval
  22. How can I get selector from jQuery object
  23. AngularJS – UI Router – programmatically add states
  24. How do I get an element to scroll into view, using jQuery?
  25. Delete from array in javascript
  26. How to Transpose / Rotate Multi-dimensional Array?
  27. Sorting a list by data-attribute
  28. backbone.js structuring nested views and models
  29. What is the difference between $scope.$root and $rootScope?
  30. HTML5 Video autoplay with sound unmuted

Leave a Comment