Override method parameter with child interface as a new parameter

by

It does break SOLID rules. You declare Car::setEngine to accept one parameter of type Engine, but the child WaterCar::setEngine accepts a parameter of type HydroEngine. Even if HydroEngine is a subtype of Engine, it’s still a different type.

When a class Foo implements WaterCar, it is also true that this class is an instanceof Car. But Foo::setEngine accepts a HydroEngine, but does not accept an Engine. So Foo::setEngine supposedly implements Car, yet does not accept a parameter of type Engine. Which breaks the Liskov substitution principle. You cannot change the type of parameters in subclassed interfaces, period.

The keyword for inheritance is explicitly extends. A subclass does exactly the same as the parent class and possibly more. It cannot do less than the parent. Since HydroEngine is a specialized subtype of Engine, this would mean a WaterCar does less than a Car, since it only accepts a more narrow subtype of Engine. E.g.:

function (Car $car) {
    $engine = new EngineImplementation;
    $car->setEngine($engine);
}

The above code would implode if you passed in a WaterCar, because it does not accept an Engine.

More Related Contents:

  1. remove duplicate key array from php [duplicate]
  2. When should I use ‘self’ over ‘$this’?
  3. Is there a use-case for singletons with database access in PHP?
  4. PHP method chaining or fluent interface?
  5. What does the variable $this mean in PHP?
  6. What is the best method to merge two PHP objects?
  7. What is the point of interfaces in PHP?
  8. Best practice on PHP singleton classes [duplicate]
  9. Why does PHP 5.2+ disallow abstract static class methods?
  10. PHP OOP core framework
  11. Multiple Inheritance in PHP
  12. Accessing Class Properties with Spaces
  13. Is it possible to create static classes in PHP (like in C#)?
  14. When should I declare variables in a PHP class?
  15. Autoload classes from different folders
  16. If Singletons are bad then why is a Service Container good?
  17. When should I use stdClass and when should I use an array in php oo code?
  18. How to use class methods as callbacks
  19. Chaining Static Methods in PHP?
  20. Dynamically create PHP object based on string
  21. Nested or Inner Class in PHP
  22. Performance of static methods vs. functions
  23. Call method by string?
  24. Why is type hinting necessary in PHP?
  25. Fatal error: Uncaught ArgumentCountError: Too few arguments to function
  26. Cannot use concatenation when declaring default class properties in PHP?
  27. Interface implementation: declaration must be compatible
  28. How do I use a class method as a callback function?
  29. unexpected ‘use’ (T_USE) when trying to use composer
  30. Expression is not allowed as field default value

Leave a Comment