The reason for the warning is that inside a loop you might be accessing a variable that is changing. However, the “fix” isn’t really doing anything for you in this non-loop context. Imagine that you had a FOR loop and the if was inside it and the string declaration was outside it. In that case … Read more
You can disable ReSharper 5 and newer versions by using the Suspend Now button in menu Tools → Options → ReSharper.
What ReSharper suggests is clearly overuse of the var keyword. You can use it where the type is obvious: var obj = new SomeObject(); If the type is not obvious, you should rather write it out: SomeObject obj = DB.SomeClass.GetObject(42);
In plain Visual Studio (since 2010) you can right click a method name (definition in interface or implementation in other class) and choose View Call Hierarchy. In Call Hierarchy window there is “Implements” folder where you can find all locations of the interface method implementation.
Implementation of All according to ILSpy (as in I actually went and looked, rather than the “well, that method works a bit like …” I might do if we were discussing the theory rather than the impact). public static bool All<TSource>(this IEnumerable<TSource> source, Func<TSource, bool> predicate) { if (source == null) { throw Error.ArgumentNull(“source”); } … Read more
Prior to C# 5, you need to re-declare a variable inside the foreach – otherwise it is shared, and all your handlers will use the last string: foreach (string list in lists) { string tmp = list; Button btn = new Button(); btn.Click += new EventHandler(delegate { MessageBox.Show(tmp); }); } Significantly, note that from C# … Read more
Not all cultures use the same format for dates and decimal / currency values. This will matter for you when you are converting input values (read) that are stored as strings to DateTime, float, double or decimal. It will also matter if you try to format the aforementioned data types to strings (write) for display … Read more
The problem with taking IEnumerable as a parameter is that it tells callers “I wish to enumerate this”. It doesn’t tell them how many times you wish to enumerate. I can change the objects parameter to be List and then avoid the possible multiple enumeration but then I don’t get the highest object that I … Read more
It is not only aesthetic, but it also reduces the maximum nesting level inside the method. This is generally regarded as a plus because it makes methods easier to understand (and indeed, many static analysis tools provide a measure of this as one of the indicators of code quality). On the other hand, it also … Read more
Performance, namespace pollution etc are all secondary in my view. Ask yourself what is logical. Is the method logically operating on an instance of the type, or is it related to the type itself? If it’s the latter, make it a static method. Only move it into a utility class if it’s related to a … Read more