Does it make sense to use “as” instead of a cast even if there is no null check? [closed]

by

Your understanding is true. That sounds like trying to micro-optimize to me. You should use a normal cast when you are sure of the type. Besides generating a more sensible exception, it also fails fast. If you’re wrong about your assumption about the type, your program will fail immediately and you’ll be able to see the cause of failure immediately rather than waiting for a NullReferenceException or ArgumentNullException or even a logical error sometime in the future. In general, an as expression that’s not followed by a null check somewhere is a code smell.

On the other hand, if you are not sure about the cast and expect it to fail, you should use as instead of a normal cast wrapped with a try-catch block. Moreover, use of as is recommended over a type check followed by a cast. Instead of:

if (x is SomeType)
   ((SomeType)x).SomeMethod();

which generates an isinst instruction for the is keyword, and a castclass instruction for the cast (effectively performing the cast twice), you should use:

var v = x as SomeType;
if (v != null)
    v.SomeMethod();

This only generates an isinst instruction. The former method has a potential flaw in multithreaded applications as a race condition might cause the variable to change its type after the is check succeeded and fail at the cast line. The latter method is not prone to this error.

The following solution is not recommended for use in production code. If you really hate such a fundamental construct in C#, you might consider switching to VB or some other language.

In case one desperately hates the cast syntax, he/she can write an extension method to mimic the cast:

public static T To<T>(this object o) { // Name it as you like: As, Cast, To, ...
    return (T)o;
}

and use a neat[?] syntax:

obj.To<SomeType>().SomeMethod()

More Related Contents:

  1. convert double to int
  2. Cast class into another class or convert class to another
  3. Invalid cast from ‘System.Int32’ to ‘System.Nullable`1[[System.Int32, mscorlib]]
  4. What is the difference between casting and conversion? [duplicate]
  5. Cannot Implicitly Convert int to int[] [closed]
  6. Convert string[] to Array
  7. How to convert numbers between hexadecimal and decimal
  8. Setting a property by reflection with a string value
  9. Is it possible to assign a base class object to a derived class reference with an explicit typecast?
  10. Cast List to List
  11. Generics and casting – cannot cast inherited class to base class
  12. How to convert a gi-normous integer (in string format) to hex format? (C#)
  13. string = string + int: What’s behind the scenes?
  14. Difference between Convert.ToString() and .ToString()
  15. Difference between casting and using the Convert.To() method
  16. How do I cast int to enum in C#?
  17. Int to Char in C#
  18. What is the difference between Convert.ToInt32 and (int)?
  19. Specifying generic collection type param at runtime [duplicate]
  20. c# Creating an unknown generic type at runtime
  21. How to cast Object to its actual type?
  22. ‘casting’ with reflection
  23. Converting an int[] to byte[] in C#
  24. C#: Dynamic runtime cast
  25. Why Enumerable.Cast raises an InvalidCastException?
  26. Converting String To Float in C#
  27. Is casting the same thing as converting?
  28. C# unsafe value type array to byte array conversions
  29. Why does null need an explicit type cast here? [duplicate]
  30. Cast IList to List

Leave a Comment